Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing old file needed for dep (no longer needed) #1316

Merged
merged 1 commit into from
Nov 25, 2019

Conversation

slim-bean
Copy link
Collaborator

This should fix the anyone using the logproto.pb.go file from registering a bunch of cortex metrics (e.g. loki-canary).

…ond import already exists in the logproto.pb.go file and the first import is already imported other places in our code.

This should fix the anyone using the logproto.pb.go file from registering a bunch of cortex metrics.
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slim-bean slim-bean merged commit 20bb95f into master Nov 25, 2019
@slim-bean slim-bean deleted the remove-dep-file branch November 25, 2019 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants