Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Add note on using Loki with Amazon ECS #1531

Merged
merged 1 commit into from
Jan 16, 2020

Conversation

fitzoh
Copy link
Contributor

@fitzoh fitzoh commented Jan 16, 2020

What this PR does / why we need it:
Add a note on how to use the Loki Docker Driver with Amazon ECS

Which issue(s) this PR fixes:
Fixes N/A

Special notes for your reviewer:
Feels a little weird tacked on to that file, but I'm not sure of a better place to put it.

Checklist

  • [✅] Documentation added
  • [N/A] Tests updated

@claassistantio
Copy link

claassistantio commented Jan 16, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Just one small comment but this LGTM

docs/clients/docker-driver/README.md Show resolved Hide resolved
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, I take that back, we already have instructions for configuring the default logging driver. LGTM!

@rfratto rfratto merged commit 4397415 into master Jan 16, 2020
@rfratto rfratto deleted the ecs-logging-docs branch January 16, 2020 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants