Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov circleci test [WIP] #1600

Merged
merged 6 commits into from
Jan 28, 2020
Merged

Codecov circleci test [WIP] #1600

merged 6 commits into from
Jan 28, 2020

Conversation

mattmendick
Copy link
Contributor

@mattmendick mattmendick commented Jan 28, 2020

This configuration adds Codecov code coverage analysis to the project. Unfortunately nothing much will happen on this one until it's merged into master because it needs the parent's code coverage to compare the branch to.

Some good stuff should begin to show up on the codecov loki page and it should begin injecting comments with code coverage analysis after it's merged into master. 🤞

@codecov-io
Copy link

codecov-io commented Jan 28, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@b6f1088). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1600   +/-   ##
=========================================
  Coverage          ?   60.68%           
=========================================
  Files             ?      106           
  Lines             ?     8052           
  Branches          ?        0           
=========================================
  Hits              ?     4886           
  Misses            ?     2782           
  Partials          ?      384

@mattmendick
Copy link
Contributor Author

Oh looks like the code coverage bot did chime in after all 🤷‍♂

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome !

Adding codecov.yml with defaults, and adding in ignoring protobuf generated files
Adding yacc generated files to codecov ignore
Newline?
@cyriltovena cyriltovena merged commit 0adad82 into master Jan 28, 2020
@cyriltovena cyriltovena deleted the codecov-circleci-test branch January 28, 2020 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants