Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for imagePullSecrets in Loki Helm chart #1632

Merged
merged 2 commits into from
Feb 6, 2020

Conversation

lukipro
Copy link
Contributor

@lukipro lukipro commented Feb 4, 2020

What this PR does / why we need it:
This PR adds support for imagePullSecrets in the Loki Helm chart. This is required if the extra container image is hosted in a local registry.

Code is taken from stable/grafana chart.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@codecov-io
Copy link

codecov-io commented Feb 4, 2020

Codecov Report

Merging #1632 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1632      +/-   ##
==========================================
- Coverage   61.74%   61.72%   -0.03%     
==========================================
  Files         109      109              
  Lines        8308     8308              
==========================================
- Hits         5130     5128       -2     
- Misses       2783     2784       +1     
- Partials      395      396       +1
Impacted Files Coverage Δ
pkg/ingester/transfer.go 65% <0%> (-1.43%) ⬇️

@@ -1,6 +1,6 @@
apiVersion: "v1"
name: loki-stack
version: 0.30.0
version: 0.31.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: 0.31.0
version: 0.31.1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a point there, will update accordingly.

@@ -1,6 +1,6 @@
apiVersion: "v1"
name: loki
version: 0.25.0
version: 0.26.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: 0.26.0
version: 0.26.1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a point there, will update accordingly.

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 9ecdcf5 into grafana:master Feb 6, 2020
mraboosk pushed a commit to mraboosk/loki that referenced this pull request Oct 7, 2024
* Added support for imagePullSecrets in Loki Helm chart

* Updating only path version for loki charts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants