Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: prune docker tags prefixed with "master-" older than 90 days #1639

Merged
merged 1 commit into from
Feb 5, 2020

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Feb 5, 2020

A tool to delete old image tags has been added, since we found out it's the cause of our Drone manifest pushing woes. This should run on merge, and deletes any images prefixed with master- from grafana/loki, grafana/promtail, and grafana/loki-canary.

The <branch>-<SHA> tags are treated as ephemeral and we can't guarantee they'll exist forever; but we can guarantee that all other tags will always exist.

@codecov-io
Copy link

Codecov Report

Merging #1639 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1639      +/-   ##
==========================================
+ Coverage   61.84%   61.86%   +0.01%     
==========================================
  Files         109      109              
  Lines        8304     8304              
==========================================
+ Hits         5136     5137       +1     
  Misses       2774     2774              
+ Partials      394      393       -1
Impacted Files Coverage Δ
pkg/promtail/targets/filetarget.go 68.71% <0%> (-1.85%) ⬇️
pkg/ingester/transfer.go 66.42% <0%> (+1.42%) ⬆️
pkg/promtail/targets/tailer.go 78.16% <0%> (+2.29%) ⬆️

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@rfratto rfratto merged commit 1fe5dc4 into grafana:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants