Allows to pass inlined pipeline stages to the docker driver. #2076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes grafana#1296 Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
|
Great news! When this going to be available or which version? |
|
As soon as one build pass on master with it, you can use latest or the tag it will spit out. |
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
See the conversation that led to this: https://cloud-native.slack.com/archives/CCYDASBLP/p1580342552117900 I personally think that 600ms is quite short, and bumping it shouldn't have a bad effect. Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1296
Long overdue, this will help to use pipeline stages with the docker driver. Turns out it's even better when using yaml compose file.
A bit more complicated when using bash.
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com