Allows to change the log driver mode and buffer size. #2116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before those configs where not allowed, but docker can use them to have a different log delivery behaviour. see https://docs.docker.com/config/containers/logging/configure/#configure-the-delivery-mode-of-log-messages-from-container-to-log-driver Potentially fixes grafana#2017 Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2116 +/- ##
==========================================
- Coverage 61.25% 61.24% -0.02%
==========================================
Files 146 146
Lines 11193 11195 +2
==========================================
Hits 6856 6856
- Misses 3791 3793 +2
Partials 546 546
|
n-saw
approved these changes
May 24, 2020
sandeepsukhani
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before those configs where not allowed, but docker can use them to have a different log delivery behaviour.
see https://docs.docker.com/config/containers/logging/configure/#configure-the-delivery-mode-of-log-messages-from-container-to-log-driver
Potentially fixes #2017
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com