-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixup: url to access promtail config sample #2597
Fixup: url to access promtail config sample #2597
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2597 +/- ##
==========================================
- Coverage 63.03% 62.97% -0.06%
==========================================
Files 169 169
Lines 15015 15015
==========================================
- Hits 9464 9456 -8
- Misses 4792 4804 +12
+ Partials 759 755 -4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
Looks like you need to sign the CLA still, (or if you did it usually goes wrong because the email on your git commit doesn't match the email you use in github, if this is the case usually the easiest fix is to modify the author email on the existing commit and force push to the branch) |
7e4e23f
to
3318f3d
Compare
Hi, I ament the commit, thanks for the advice about the mail, I didn't know about it ! CLA approved ;) |
Thanks @nek-00-ken! |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist