Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/loki: add "verify-config" flag #2737

Merged
merged 1 commit into from
Oct 12, 2020
Merged

cmd/loki: add "verify-config" flag #2737

merged 1 commit into from
Oct 12, 2020

Conversation

dlemel8
Copy link
Contributor

@dlemel8 dlemel8 commented Oct 8, 2020

This flag load and verify configuration and exits with proper exit code

Fixes #2713

@CLAassistant
Copy link

CLAassistant commented Oct 8, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

Codecov Report

Merging #2737 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2737      +/-   ##
==========================================
+ Coverage   61.39%   61.44%   +0.05%     
==========================================
  Files         173      173              
  Lines       13465    13465              
==========================================
+ Hits         8267     8274       +7     
+ Misses       4445     4435      -10     
- Partials      753      756       +3     
Impacted Files Coverage Δ
pkg/promtail/targets/file/tailer.go 70.09% <0.00%> (-5.61%) ⬇️
pkg/logql/evaluator.go 92.81% <0.00%> (+0.42%) ⬆️
pkg/promtail/positions/positions.go 58.51% <0.00%> (+11.70%) ⬆️

@zswanson
Copy link

Looks good to me! 👍

Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition!

@owen-d owen-d merged commit 9a3592c into grafana:master Oct 12, 2020
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Oct 21, 2020
… with proper exit code (grafana#2737)

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

config validator for CI checks
5 participants