Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add using_boltdb_shipper to environments/loki/main.jsonnet sample #2936

Closed
wants to merge 4 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/sources/installation/tanka.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,11 @@ loki + promtail + gateway {
namespace: 'loki',
htpasswd_contents: 'loki:$apr1$H4yGiGNg$ssl5/NymaGFRUvxIV1Nyr.',

// Set to true if using boltdb shipper and uncomment boltdb_shipper_shared_store below
using_boltdb_shipper: false,

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sandeepsukhani should we mention about index_period here. I understand it only matters if default value differs during migration. Still wondering should we still make a note? WDYT?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should rewrite this example config with boltdb shipper as index store because we are defaulting to it now.
Regarding comment, I think it should be there in source jsonnet but I don't mind it being added here too.

// boltdb_shipper_shared_store: {}

// S3 variables remove if not using aws
storage_backend: 's3,dynamodb',
s3_access_key: 'key',
Expand Down