fix table deletion in table client for boltdb-shipper #2960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyriltovena
reviewed
Nov 23, 2020
| @@ -48,7 +48,7 @@ func (b *boltDBShipperTableClient) Stop() { | |||
| } | |||
|
|
|||
| func (b *boltDBShipperTableClient) DeleteTable(ctx context.Context, name string) error { | |||
| objects, dirs, err := b.objectClient.List(ctx, name, delimiter) | |||
| objects, dirs, err := b.objectClient.List(ctx, name+delimiter, delimiter) | |||
There was a problem hiding this comment.
You should add a test for this.
There was a problem hiding this comment.
A test is there but it uses filesystem object client which works with or without a delimiter, we don't have an easy way to test this with hosted object stores without mocking the client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When listing contents of a directory in hosted object stores(s3, gcs etc), it needs to end with a separator otherwise get the list of all the directories starting with that prefix. The code was missing the delimiter causing deletion operation to find directories instead of files and hence fail the deletion operation.
This PR fixes it by adding a delimiter to the name of the table during list operation.