Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swaps mutex for atomic in ingester's OnceSwitch #3141

Merged
merged 1 commit into from
Jan 7, 2021

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Jan 7, 2021

benchmark                  old ns/op     new ns/op     delta
Benchmark_OnceSwitch-8     13418         5743          -57.20%

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #3141 (44b5e10) into master (ed649ee) will increase coverage by 0.02%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3141      +/-   ##
==========================================
+ Coverage   63.11%   63.13%   +0.02%     
==========================================
  Files         188      188              
  Lines       16312    16305       -7     
==========================================
- Hits        10295    10294       -1     
+ Misses       5078     5069       -9     
- Partials      939      942       +3     
Impacted Files Coverage Δ
pkg/ingester/instance.go 60.28% <80.00%> (-1.31%) ⬇️
pkg/querier/queryrange/limits.go 91.66% <0.00%> (-4.17%) ⬇️
pkg/logql/evaluator.go 90.23% <0.00%> (+0.35%) ⬆️
pkg/promtail/targets/file/filetarget.go 64.33% <0.00%> (+0.69%) ⬆️
pkg/canary/comparator/comparator.go 78.18% <0.00%> (+1.81%) ⬆️
pkg/querier/queryrange/downstreamer.go 97.64% <0.00%> (+2.35%) ⬆️

@owen-d owen-d merged commit 9505294 into grafana:master Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants