fix(pkg/promtail): CVE-2020-11022: upgraded to jquery to 3.5.1 from 3.3.1 #3222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backup jquery(3.3.1) to jquery.min.js, added jquery-3.5.1.js, updated reference in base template
|
|
executed make check-generated-files
veltmanj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backup jquery(3.3.1) to jquery.min.js, added jquery-3.5.1.js, updated reference in base template
What this PR does / why we need it:
Lifecycle management and security.
Which issue(s) this PR fixes:
Fixes #
Fixes# #3185
Special notes for your reviewer:
This issue seems as far as I know isolated to Promtail. Grafana seems to use the correct jQuery version.
Unfortunately I could not find any particular tests for these files. But imho the impact seems low.
Checklist