Fix a bug with metric queries and label_format. #3263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my previous PR where I introduced hints, I forgot to implement label format label required. This would cause label format label to be skipped during parsing. I've also took the opportunity to improve the code. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #3263 +/- ##
==========================================
+ Coverage 63.20% 63.28% +0.08%
==========================================
Files 199 199
Lines 16875 16893 +18
==========================================
+ Hits 10665 10691 +26
+ Misses 5245 5233 -12
- Partials 965 969 +4
|
kavirajk
reviewed
Jan 29, 2021
kavirajk
reviewed
Jan 29, 2021
Made some mistake will add more tests in the logql package to ensure this optimization is not breaking anything it's the second time and I think it's because I don't have a good test story. |
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my previous PR where I introduced hints, I forgot to implement label format label required.
This would cause label format label to be skipped during parsing.
I've also took the opportunity to improve the code.
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com