Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: add note about wildcard log patterns and log rotation #3655

Merged
merged 1 commit into from
Apr 26, 2021

Conversation

trevorwhitney
Copy link
Collaborator

Signed-off-by: Trevor Whitney trevorjwhitney@gmail.com

What this PR does / why we need it:

Adds a note about avoid re-ingesting rotated logs because of overly permissive log match patterns.

Checklist

  • Documentation added
  • Tests updated

Signed-off-by: Trevor Whitney <trevorjwhitney@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Apr 26, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@owen-d owen-d merged commit 2f29e8e into main Apr 26, 2021
@owen-d owen-d deleted the docs-log-rotate branch April 26, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants