Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document known Docker driver issues. #4190

Merged
merged 4 commits into from
Aug 23, 2021

Conversation

jeschkies
Copy link
Contributor

@jeschkies jeschkies commented Aug 18, 2021

What this PR does / why we need it:
The Docker driver might seem stuck when Loki is not reachable. It might also drop log entries. In this change we describe how to use Promtail instead.

Which issue(s) this PR fixes:
Relates to #2361

Checklist

  • Documentation added

static_configs:
- labels:
job: docker
__path__: /var/lib/docker/containers/*/*-json.log
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: will it always be JSON logs? (just *-json.log bugs me, can it be just *.log instead?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. The Docker pipeline steps requires the JSON log driver which is the default.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Thanks for clarification! :)

Copy link
Contributor

@kavirajk kavirajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@KMiller-Grafana KMiller-Grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see the wording improved, but it is not necessary. I approve with or without changes.

docs/sources/clients/docker-driver/_index.md Outdated Show resolved Hide resolved
docs/sources/clients/docker-driver/_index.md Outdated Show resolved Hide resolved
docs/sources/clients/docker-driver/_index.md Outdated Show resolved Hide resolved
jeschkies and others added 3 commits August 23, 2021 11:30
Co-authored-by: Karen Miller <84039272+KMiller-Grafana@users.noreply.github.com>
Co-authored-by: Karen Miller <84039272+KMiller-Grafana@users.noreply.github.com>
Co-authored-by: Karen Miller <84039272+KMiller-Grafana@users.noreply.github.com>
@dannykopping dannykopping merged commit e25587b into grafana:main Aug 23, 2021
@jeschkies jeschkies deleted the karsten/document-promtail-docker branch August 23, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants