cmd/logcli: add --follow flag as an alias for --tail #4203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dannykopping
approved these changes
Aug 23, 2021
|
@invidian before I merge this, can you please update the documentation? It's in |
When using 'logcli query --tail', '--tail' behaves similar to the 'tail' command, which uses '--follow' flag, if you want to continuously follow the appended data to the file. I believe '--follow' flag is more natural for system administrators to use rather than '--tail' if one wants to "follow" the incoming logs, so this commit adds one, as an alias for '--tail'. Closes grafana#3570 Signed-off-by: Mateusz Gozdek <mgozdekof@gmail.com>
invidian
force-pushed
the
add-follow-flag-to-logcli
branch
from
f375555
to
0a81fba
Compare
Sure, done. |
|
Many thanks! |
|
Thanks for quick merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When using 'logcli query --tail', '--tail' behaves similar to the 'tail'
command, which uses '--follow' flag, if you want to continuously
follow the appended data to the file.
I believe '--follow' flag is more natural for system administrators to
use rather than '--tail' if one wants to "follow" the incoming logs, so
this commit adds one, as an alias for '--tail'.
Which issue(s) this PR fixes:
Fixes #3570
Special notes for your reviewer:
Signed-off-by: Mateusz Gozdek mgozdekof@gmail.com
Checklist