Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Register configuration option store.max-look-back-period as CLI argument #4242

Merged
merged 2 commits into from
Sep 7, 2021

Conversation

chaudum
Copy link
Contributor

@chaudum chaudum commented Aug 31, 2021

What this PR does / why we need it:

As the title suggests, this PR register a (deprecated) configuration option as CLI argument.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

This will help towards auto-generating reference documentation from source.

Checklist

  • Documentation added
  • Tests updated

@chaudum chaudum requested a review from a team as a code owner August 31, 2021 09:54
@CLAassistant
Copy link

CLAassistant commented Aug 31, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, then LGTM

pkg/storage/store.go Outdated Show resolved Hide resolved
@chaudum chaudum changed the title cli: Register configuration options store.chunks-cache.max-look-back-period and querier.split-queries-by-interval as CLI arguments cli: Register configuration option store.max-look-back-period as CLI arguments Sep 1, 2021
@chaudum chaudum changed the title cli: Register configuration option store.max-look-back-period as CLI arguments cli: Register configuration option store.max-look-back-period as CLI argument Sep 1, 2021
Even though the flag is already deprecated, registering the flag is necessary
for generating the config reference documentation.
@chaudum chaudum force-pushed the chaudum/register-config-options branch from 01e756e to 6770f22 Compare September 1, 2021 11:48
@chaudum
Copy link
Contributor Author

chaudum commented Sep 2, 2021

@owen-d Not sure why CI fails

pkg/storage/store.go Outdated Show resolved Hide resolved
@owen-d owen-d merged commit 0f229f4 into main Sep 7, 2021
@owen-d owen-d deleted the chaudum/register-config-options branch September 7, 2021 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants