Chore: Use dskit/grpcclient #4312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknuds1
force-pushed
the
chore/use-dskit-grpc
branch
from
fabbb52
to
e080605
Compare
aknuds1
force-pushed
the
chore/use-dskit-grpc
branch
3 times, most recently
from
ed503bd
to
95bf4d8
Compare
owen-d
approved these changes
Sep 21, 2021
aknuds1
force-pushed
the
chore/use-dskit-grpc
branch
from
95bf4d8
to
c823af9
Compare
aknuds1
force-pushed
the
chore/use-dskit-grpc
branch
from
c823af9
to
b19a2bb
Compare
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1
force-pushed
the
chore/use-dskit-grpc
branch
from
b19a2bb
to
093992c
Compare
sandeepsukhani
approved these changes
Oct 11, 2021
slim-bean
added a commit
that referenced
this pull request
Oct 14, 2021
…ince #4312 was merged after the original fork was created.
trevorwhitney
pushed a commit
that referenced
this pull request
Oct 18, 2021
…ince #4312 was merged after the original fork was created.
trevorwhitney
pushed a commit
that referenced
this pull request
Oct 20, 2021
…ince #4312 was merged after the original fork was created.
trevorwhitney
pushed a commit
that referenced
this pull request
Oct 21, 2021
…ince #4312 was merged after the original fork was created.
slim-bean
added a commit
that referenced
this pull request
Oct 21, 2021
…ng as an alternative to DNS (#4424) * Fork the frontend and scheduler so we can add support for discovery via the ring. * Add a ring to the query scheduler which is then used by the frontend worker and querier workers to find the scheduler address as an alternative to using DNS * update some of the forked code to use dskit grpcclient and grpcutil since #4312 was merged after the original fork was created. * remove query scheduler dependency from querier Signed-off-by: Trevor Whitney <trevorjwhitney@gmail.com> * migrate logging package and make linter happy Signed-off-by: Trevor Whitney <trevorjwhitney@gmail.com> * add SafeReadRing for instances when scheduler is not enabled on same instance * Doc changes from code review A few doc fixes Co-authored-by: Karen Miller <84039272+KMiller-Grafana@users.noreply.github.com> * go mod tidy on go-kit dep * update changelog * remove ReadRing in favor of SafeReadRing Co-authored-by: Trevor Whitney <trevorjwhitney@gmail.com> Co-authored-by: Karen Miller <84039272+KMiller-Grafana@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Use dskit/grpcclient instead of the one from Cortex.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist