clients/promtail: Add ndjson and plaintext formats to loki_push #4336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
KMiller-Grafana
suggested changes
Sep 15, 2021
cyriltovena
reviewed
Sep 16, 2021
cyriltovena
reviewed
Sep 16, 2021
cyriltovena
reviewed
Sep 16, 2021
KMiller-Grafana
approved these changes
Sep 28, 2021
There was a problem hiding this comment.
The documentation portion of this PR looks good to me. Thanks for the changes, @ldb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This change adds a generic way to send logs to Loki via HTTP. To do that it introduces a
formatoption to theloki_push_apiscrape target, which can be used to describe what kind of format should be accepted:lokiis the currently accepted snappy RPC formatplaintextandndjsonare newline delimited text formats. Each line in the request body will render a longline in LokiWhich issue(s) this PR fixes:
Fixes #4316
Special notes for your reviewer:
Checklist