Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric prefix changes for chunk store and runtime config to upgrading.md #4436

Conversation

JordanRushing
Copy link
Contributor

@JordanRushing JordanRushing commented Oct 7, 2021

What this PR does / why we need it:
Important changes between versions should be noted in docs/sources/upgrading/.

Which issue(s) this PR fixes:
Closes #4257

Special notes for your reviewer:
N/A

Checklist

  • Documentation added
  • Tests updated

@JordanRushing JordanRushing self-assigned this Oct 7, 2021
@JordanRushing JordanRushing marked this pull request as ready for review October 7, 2021 23:42
@JordanRushing JordanRushing changed the title Add metric prefix changes for chunk store and runtime config to upgra… Add metric prefix changes for chunk store and runtime config to upgrading.md Oct 8, 2021
Copy link
Contributor

@kavirajk kavirajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. just one nit :)

docs/sources/upgrading/_index.md Show resolved Hide resolved
Copy link
Contributor

@KMiller-Grafana KMiller-Grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc update looks good to me.

@JordanRushing JordanRushing force-pushed the jordanrushing/loki/add-metrix-prefix-changes-to-upgrading-doc branch from fd1551c to a178f9b Compare October 14, 2021 20:32
@owen-d owen-d merged commit afbbc2f into grafana:main Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.4 Upgrade.md should include the metric prefix changes:
5 participants