Feature: add virtual read and write targets #4498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevorwhitney
changed the title
trevorwhitney
force-pushed
the
ring-scheduler
branch
from
16ae43c
to
61d035f
Compare
trevorwhitney
force-pushed
the
enable-read-write
branch
from
7b3625e
to
a77f1f7
Compare
trevorwhitney
force-pushed
the
ring-scheduler
branch
from
5b83af8
to
2553167
Compare
trevorwhitney
force-pushed
the
enable-read-write
branch
from
c229a72
to
19db681
Compare
Co-Authored-By: Mauro Stettler <mauro.stettler@gmail.com>
trevorwhitney
force-pushed
the
enable-read-write
branch
from
19db681
to
d1f3516
Compare
dannykopping
approved these changes
Oct 25, 2021
There was a problem hiding this comment.
Looks great @trevorwhitney - are we going to document this in a separate PR?
|
Yes, we are going to document this in a later separate PR. |
|
@dannykopping good call out, @DylanGuedes is helping me out and is doing the docs PR separately (thanks again Dylan, I owe you one) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: Mauro Stettler mauro.stettler@gmail.com
What this PR does / why we need it:
Replaces #4397, adds virtual target of read and write to loki. These are needed to support the new "single scalable deployment" deployment strategy, offering users a deployment topology that is easier to deploy/understand than micro-services, while also being more resilient and scalable than single binary.
This adds a couple extra lines of code that were needed on top of #4397, and since @replay is off, I'm taking the the torch on this one.
Checklist
Tests updatedN/A