Apply better defaults when boltdb shipper is being used #4508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevorwhitney
changed the title
trevorwhitney
force-pushed
the
boltdb-defaults
branch
from
dd6fdb3
to
268fb34
Compare
owen-d
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds logic to the
ApplyDynamicConfigfunction that will pick better defaults for chunk storage configuration and compactor storage configuration. If the current schema is using BoltDB, it will set the defaultshared_storefor bothboltdb.shipper.shared-storeandboltdb.shipper.compactor.shared-storeto the value of the current schema'sobject-store.Checklist