Logql stdin support only log queries
#4606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavirajk
changed the title
stdin support only log queries
|
|
@KMiller-Grafana Addressed your comments! |
kavirajk
requested review from
a team,
slim-bean and
cyriltovena
and removed request for
a team
cyriltovena
reviewed
Nov 16, 2021
cyriltovena
reviewed
Nov 16, 2021
cyriltovena
reviewed
Nov 16, 2021
jeschkies
reviewed
Nov 16, 2021
Add flag to choose what kind of client to make request to. Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
Issue was with default value of `step` (1 nanosecond). StepEvaluator try to go through every nanosecond to apply aggregate on sample data during the metric queries. Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
1. Add `--stdin` in examples of the usage 2. Add `--stdin` in all the command help output
- Use parsed labels correctly - Fix indendation with --stdin flag
jeschkies
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add support for
--stdinCLI flag for Loki, to read log data without requiring loki servers.It was a followup idea from last hackathon!
NOTE: Currently we just support log queries (metrics are not supported yet)
Which issue(s) this PR fixes:
Fixes # partly #3393
Special notes for your reviewer:
Checklist
CHANGELOG.mdabout the changes.