Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uses ring.Write instead of ring.WriteNoExtend for compactor ring checks #4615

Merged
merged 1 commit into from
Nov 2, 2021
Merged

uses ring.Write instead of ring.WriteNoExtend for compactor ring checks #4615

merged 1 commit into from
Nov 2, 2021

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Nov 2, 2021

ring.WriteNoExtend won't keep iterating the ring until an active node is picked, so I think we should use ring.Write here instead. This is the same idea from #4607

@owen-d owen-d requested a review from a team as a code owner November 2, 2021 18:21
slim-bean
slim-bean approved these changes Nov 2, 2021
View reviewed changes
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-d owen-d merged commit 308af87 into grafana:main Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slim-bean slim-bean slim-bean approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@owen-d @slim-bean