Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: simplify how protos are built #4639

Merged
merged 5 commits into from
Nov 4, 2021
Merged

Build: simplify how protos are built #4639

merged 5 commits into from
Nov 4, 2021

Commits on Nov 3, 2021

  1. we always seem to be chasing our tails with how protos are generated … 

    …and Makes use of timestamps to determine if files should be recompiled. Instead of touching files and altering timestamps always delete the compiled proto files when calling `protos` to make sure they are compiled every time.

Removed targets to build protos, yaccs, and ragel files when trying to build loki or the canary. This isn't necesary, if you are changing these files you would know you need to build them and the `check-generated-files` should catch any changes to them not committed.
    @slim-bean
    slim-bean committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    4848bed View commit details
    Browse the repository at this point in the history

  2. rm -rf

    @slim-bean
    slim-bean committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    9d62dc6 View commit details
    Browse the repository at this point in the history

  3. we have a race between check-generated-files and our other steps, so … 

    …let that run first.

also removing `check-generated-files` from the `all` target because its redundant with a separate step and could also race with the parallel lint
    @slim-bean
    slim-bean committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    9ec1b0e View commit details
    Browse the repository at this point in the history

  4. remove TOUCH_PROTOS

    @slim-bean
    slim-bean committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    9ea23d3 View commit details
    Browse the repository at this point in the history

  5. more cleanup of TOUCH_PROTOS

    @slim-bean
    slim-bean committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    31d93fe View commit details
    Browse the repository at this point in the history