Loki: Implement common net interface/instance addr #4950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 22, 2021
owen-d
reviewed
Jan 3, 2022
| // - "instance-addr", the address advertised to be used by other components. | ||
| // - "instance-interface-names", a list of net interfaces used when looking for addresses. | ||
| func applyInstanceConfigs(r, defaults *ConfigWrapper) { | ||
| if !reflect.DeepEqual(r.Common.InstanceAddr, defaults.Common.InstanceAddr) { |
There was a problem hiding this comment.
If we only ever check if r.Common.InstanceAddr != defaults.Common.InstanceAddr, is there a reason common.instance-addr should default to 127.0.0.1 instead of ""?
There was a problem hiding this comment.
Hmm I'd say there's no reason then. Let me change it to "" instead.
DylanGuedes
force-pushed
the
add-common-netinterface
branch
3 times, most recently
from
ec6838d
to
4796880
Compare
|
Enabling auto merge that should merge once conflict resolve. |
- Implement two new common configurations: instance_interface_names, which is a list of net interfaces used to discover addresses and instance_addr, used to advertise a component address.
DylanGuedes
force-pushed
the
add-common-netinterface
branch
from
4796880
to
6be2021
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
instance_interface_names, a common net interface used by components internally to look for addresses. The list order matters, as components internally iterate over the list until they find a valid address. If the common ring section specifies aninstance_interface_names, this configuration is only applied to the frontend but not to other components.instance_addr, a common instance address used by components to advertise their address. Again, if the common ring section specifies aninstance_addr, this configuration is only applied to the frontend (since it is not a ring) but not to other components.Which issue(s) this PR fixes:
Fixes #4897
Special notes for your reviewer:
Checklist
CHANGELOG.mdabout the changes.