Removes split-by upstream validation #5087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
|
The configuration is embedded, defining the validate method will call our version not the embedded anymore. |
owen-d
approved these changes
Jan 10, 2022
|
Again just to make sure everyones understand this is a hotfix to avoid breaking change, not a real solution. |
dannykopping
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5023 Removes the global split by configuration but we still have validation from upstream code configuration.
This PR removes the validation, while it is valid for a non multi tenant split-by in our case the validation is actually not working as we could override a tenant to a split-by zero and this means it would break his read path.
I understand this doesn't solve the problem (which we need to figure how to) but at least it really makes the global split-by unused.
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com