Ruler: Fix remote write basic auth credentials #5144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 14, 2022 11:42
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
dannykopping
commented
Jan 14, 2022
| @@ -191,7 +191,7 @@ func TestTenantRemoteWriteHTTPConfigMaintained(t *testing.T) { | |||
|
|
|||
| // HTTP client config is not currently overrideable, all tenants' configs should inherit base | |||
| assert.Equal(t, tenantCfg.RemoteWrite[0].HTTPClientConfig.BasicAuth.Username, "foo") | |||
| assert.Equal(t, tenantCfg.RemoteWrite[0].HTTPClientConfig.BasicAuth.Password, promConfig.Secret("<secret>")) | |||
There was a problem hiding this comment.
I was obviously having a dumb day when I wrote this 🙃
owen-d
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Danny Kopping danny.kopping@grafana.com
What this PR does / why we need it:
A community member reported that a configured basic auth password was being sent via HTTP as
<secret>. The reason for this is that value is stored in aSecrettype, which - when marshaled, obfuscated the original password to<secret>.Big thanks to @kingjan1999 for the report and the fix.
Which issue(s) this PR fixes:
Fixes #5140
Special notes for your reviewer:
Checklist
CHANGELOG.mdabout the changes.