Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup common index set after cleaning up all the user index sets #5372

Merged
merged 2 commits into from
Feb 11, 2022
Merged

cleanup common index set after cleaning up all the user index sets #5372

merged 2 commits into from
Feb 11, 2022

Conversation

sandeepsukhani
Copy link
Contributor

What this PR does / why we need it:
Always clean up the common index set after cleaning up the user index sets on the read path of boltdb-shipper.

@sandeepsukhani sandeepsukhani requested a review from a team as a code owner February 11, 2022 12:57
chaudum
chaudum reviewed Feb 11, 2022
View reviewed changes
Copy link
Contributor

@chaudum chaudum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would make sense to extract the logic into a separate function that then could also be tested independently.

kavirajk
kavirajk approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@kavirajk kavirajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!. Thanks @sandeepsukhani

@pull-request-size pull-request-size bot added size/M and removed size/S labels Feb 11, 2022
@sandeepsukhani sandeepsukhani merged commit da9b4c9 into grafana:main Feb 11, 2022
@dannykopping dannykopping mentioned this pull request Feb 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaudum chaudum chaudum approved these changes

@kavirajk kavirajk kavirajk approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sandeepsukhani @chaudum @kavirajk