Loki: include the component in metrics.go log line #5379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Welch <edward.welch@grafana.com>
owen-d
approved these changes
Feb 12, 2022
Signed-off-by: Edward Welch <edward.welch@grafana.com>
Signed-off-by: Edward Welch <edward.welch@grafana.com>
jeschkies
approved these changes
Feb 15, 2022
| var ( | ||
| logger = util_log.WithContext(ctx, util_log.Logger) | ||
| logger = util_log.WithContext(ctx, log) |
There was a problem hiding this comment.
🎉 we should get rid off util_log.Logger altogether 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When running the single binary or in SSD mode, it's essentially impossible to disambiguate metrics.go output from the querier executing a subquery and the accumulated result output by the frontend.
This PR introduces a component to the logger to easily tell which component is outputting the metrics.go stats
Special notes for your reviewer:
Checklist
CHANGELOG.mdabout the changes.