Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default installation namespace on OpenShift #5441

Merged
merged 3 commits into from
Feb 24, 2022

Conversation

sasagarw
Copy link

@sasagarw sasagarw commented Feb 22, 2022

What this PR does / why we need it:

  • updates the default namespace for openshift to openshift-operators-redhat.
  • updates the reference from loki.openshift.io -> loki.grafana.com

Which issue(s) this PR fixes:
Fixes #5440

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated
  • Add an entry in the CHANGELOG.md about the changes.

Copy link
Collaborator

@xperimental xperimental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, only some minor changes.

While looking at the PR I came across the --install-mode which is currently set to OwnNamespace. Is this still correct when we plan to have the operator running in openshift-operators-redhat but Loki deployed to openshift-logging?

operator/docs/hack_operator_make_run.md Outdated Show resolved Hide resolved
operator/Makefile Outdated Show resolved Hide resolved
@sasagarw
Copy link
Author

@xperimental yeah it works fine when I try to deploy operator in openshift-operators-redhat and lokistack in openshift-logging. Didn't find any issue in running the complete stack.

Copy link
Collaborator

@xperimental xperimental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, something just occurred to me while looking at it the second time: The later instructions in hack_loki_operator.md still correctly reference the openshift-logging namespace because we intend to run Loki in that namespace, but the first command referencing the namespace will fail if it does not exist.

Does it make sense to add a paragraph to the doc for creating the namespace before trying to add resources to it? In the document that would be before adding the AWS secret.

@xperimental xperimental changed the title [operator] Install operator in openshift-operators-redhat ns Change default installation namespace on OpenShift Feb 23, 2022
@periklis periklis merged commit 56cebfc into grafana:main Feb 24, 2022
@sasagarw sasagarw deleted the update-namespace branch March 23, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[operator] Installation of operator in different namespace for OpenShift
3 participants