Do not insert missing point when sharding #5444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyriltovena
changed the title
owen-d
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I recently runs into a problem with the query-frontend where the query wasn't the right result but the querier would return the right result.
Turns out this is due to querysharding, when doing sharding we actually insert missing 0 point when stepping on the results of each shards.
However this is wrong, zero during a min_over_time means something different, or even when dividing during a binary operations this can cause the creation of NaN.
The solution is simple we don't need to insert those points.
Which issue(s) this PR fixes:
Fixes #5438
Special notes for your reviewer:
Checklist
CHANGELOG.mdabout the changes.