Querier: prevent unnecessary calls to ingesters #5984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o overlap within the query_ingesters_within value
…o overlap within the query_ingesters_within value
…o series-maxlookback
salvacorts
reviewed
Apr 21, 2022
This was referenced Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
For the labels, label values, and series APIs, we are currently not checking if the given query's time range is within the
query_ingesters_withinlookback period. This results in unnecessary (and often unsuccessful) queries to ingesters for non-recent data.Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
We noticed this while conducting some load tests which queried old data, which resulted in high CPU usage on ingesters; this didn't make sense as ingesters only hold recent data, which is then written to chunks and flushed to object storage. Queriers querying old data should only query the object store, not the ingesters.
Checklist
CHANGELOG.md.docs/sources/upgrading/_index.md