Add unwrapped aggregation rate_counter()
#6412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`rate_counter()` takes an unwrapped range as input, but unlike `rate()` it treats the values extracted from the log lines as "counter metric" like in Prometheus' `rate()` function. This is a replacement for the reverted change of #5013 Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
chaudum
commented
Jun 16, 2022
| @@ -9,7 +9,6 @@ | |||
| * [6372](https://github.com/grafana/loki/pull/6372) **splitice**: Add support for numbers in JSON fields | |||
| * [6105](https://github.com/grafana/loki/pull/6105) **rutgerke** Export metrics for the promtail journal target | |||
| * [6179](https://github.com/grafana/loki/pull/6179) **chaudum**: Add new HTTP endpoint to delete ingester ring token file and shutdown process gracefully | |||
| * [6099](https://github.com/grafana/loki/pull/6099/files) **cstyan**: Drop lines with malformed JSON in Promtail JSON pipeline stage | |||
There was a problem hiding this comment.
Duplicate changlog entry (line 5)
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
- querier/queryrange -0.1%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
owen-d
approved these changes
Jun 16, 2022
ssncferreira
added
the
backport release-2.6.x
grafanabot
pushed a commit
that referenced
this pull request
Jun 30, 2022
`rate_counter()` takes an unwrapped range as input, but unlike `rate()` it treats the values extracted from the log lines as "counter metric" like in Prometheus' `rate()` function. This is a replacement for the reverted change of #5013 Signed-off-by: Christian Haudum <christian.haudum@gmail.com> (cherry picked from commit a56a88b)
ssncferreira
added a commit
that referenced
this pull request
Jun 30, 2022
* Add unwrapped aggregation `rate_counter()` (#6412) `rate_counter()` takes an unwrapped range as input, but unlike `rate()` it treats the values extracted from the log lines as "counter metric" like in Prometheus' `rate()` function. This is a replacement for the reverted change of #5013 Signed-off-by: Christian Haudum <christian.haudum@gmail.com> (cherry picked from commit a56a88b) * Update CHANGELOG Co-authored-by: Christian Haudum <christian.haudum@gmail.com> Co-authored-by: Susana Ferreira <susana.ferreira@grafana.com>
osg-grafana
added
type/docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
rate_counter()takes an unwrapped range as input, but unlikerate()it treats the values extracted from the log lines as "counter metric"
like in Prometheus'
rate()function.This is a replacement for the reverted change of #5013
Special notes for your reviewer:
Part to of the implementation of #6351
Checklist
CHANGELOG.md.docs/sources/upgrading/_index.md