Add TLS config to query frontend #6444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
There was a problem hiding this comment.
Thanks for the contribution @aminesnow 👍
Added a couple comments
dannykopping
approved these changes
Jun 21, 2022
added 2 commits
June 21, 2022 15:41
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
- loki -0.3% |
aminesnow
pushed a commit
to aminesnow/loki
that referenced
this pull request
Jun 21, 2022
4 tasks
periklis
pushed a commit
that referenced
this pull request
Jun 22, 2022
4 tasks
osg-grafana
added
type/docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds TLS configuration parameters to query frontend. Without this, the live tailing on Openshift cluster cannot work.
Which issue(s) this PR fixes:
Fixes #5743
Special notes for your reviewer:
This PR is needed for this operator fix PR #6443
Checklist
CHANGELOG.md.docs/sources/upgrading/_index.md