Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rangemapper with VectorExpr support #7288

Merged
merged 2 commits into from
Sep 29, 2022
Merged

Fix rangemapper with VectorExpr support #7288

merged 2 commits into from
Sep 29, 2022

Conversation

ssncferreira
Copy link
Contributor

@ssncferreira ssncferreira commented Sep 29, 2022 •
edited
Loading

What this PR does / why we need it:
The new expression type VectorExpr introduced recently in PR, is not taken into account in the query mapping in the AST mapper rangemapper.
The AST mapper shardmapper was updated in PR.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md

@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

@ssncferreira ssncferreira marked this pull request as ready for review September 29, 2022 10:31
@ssncferreira ssncferreira requested a review from a team as a code owner September 29, 2022 10:31
@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

1 similar comment
@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

@ssncferreira ssncferreira merged commit 10e9695 into main Sep 29, 2022
@ssncferreira ssncferreira deleted the ast_rangemapper_vector_support branch September 29, 2022 11:08
lxwzy pushed a commit to lxwzy/loki that referenced this pull request Nov 7, 2022
@ssncferreira @lxwzy
Fix rangemapper with VectorExpr support (grafana#7288)
7ea02a8 
**What this PR does / why we need it**:
The new expression type VectorExpr introduced recently in
[PR](grafana#7007), is not taken into
account in the query mapping in the AST mapper rangemapper.
The AST mapper shardmapper was updated in
[PR](grafana#7045).

**Special notes for your reviewer**:

**Checklist**
- [ ] Reviewed the `CONTRIBUTING.md` guide
- [ ] Documentation added
- [x] Tests updated
- [x] `CHANGELOG.md` updated
- [ ] Changes that require user attention or interaction to upgrade are
documented in `docs/sources/upgrading/_index.md`
changhyuni pushed a commit to changhyuni/loki that referenced this pull request Nov 8, 2022
@ssncferreira @changhyuni
Fix rangemapper with VectorExpr support (grafana#7288)
3dfccd6 
**What this PR does / why we need it**:
The new expression type VectorExpr introduced recently in
[PR](grafana#7007), is not taken into
account in the query mapping in the AST mapper rangemapper.
The AST mapper shardmapper was updated in
[PR](grafana#7045).

**Special notes for your reviewer**:

**Checklist**
- [ ] Reviewed the `CONTRIBUTING.md` guide
- [ ] Documentation added
- [x] Tests updated
- [x] `CHANGELOG.md` updated
- [ ] Changes that require user attention or interaction to upgrade are
documented in `docs/sources/upgrading/_index.md`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owen-d owen-d owen-d approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ssncferreira @grafanabot @owen-d