-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promtail: Fix collecting userdata field from Windows Event Log #7461
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting and fixing the bug!
LGTM
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
…na#7461) **What this PR does / why we need it**: The windows event log target for Promtail had a typo that led to `EventData` being assigned to `UserData`. This PR fixes this typo. **Which issue(s) this PR fixes**: Fixes grafana#6167
…na#7461) **What this PR does / why we need it**: The windows event log target for Promtail had a typo that led to `EventData` being assigned to `UserData`. This PR fixes this typo. **Which issue(s) this PR fixes**: Fixes grafana#6167
**What this PR does / why we need it**: Windows Event Logs have an Event Message field that is intended for human eyes, and often contains data that already present in the event data XML. Omitting this field the same way we can already omit `user_data` and `event_data` can easily save a lot of bytes of data per event - Event ID 4264 alone has ~2KB of just text that is already present in `event_data`. **Which issue(s) this PR fixes**: Fixes #7395 **Special notes for your reviewer**: I also took the liberty to improve upon the existing test '`Test_renderEntries` by using unique values for each field rather than 10's everywhere. I expect this to conflict with my other PR, #7461.
- PR grafana#7462 and grafana#7461 were **not** included in the 2.7.x release (they were submitted right after the cutoff and did not get backported) and accidentally ended up in the 2.7.x changelog. Moved them up to Main/Unreleased. - Moved grafana#7602 to enhancements section of Promtail
… 2.7.x (#7690) Fixes the changelog. - PR #7462 and #7461 were **not** included in the 2.7.x release (they were submitted right after the cutoff and did not get backported) and accidentally ended up in the 2.7.x changelog. Moved them up to Main/Unreleased. - Moved #7602 to enhancements section of Promtail
…na#7461) **What this PR does / why we need it**: The windows event log target for Promtail had a typo that led to `EventData` being assigned to `UserData`. This PR fixes this typo. **Which issue(s) this PR fixes**: Fixes grafana#6167
**What this PR does / why we need it**: Windows Event Logs have an Event Message field that is intended for human eyes, and often contains data that already present in the event data XML. Omitting this field the same way we can already omit `user_data` and `event_data` can easily save a lot of bytes of data per event - Event ID 4264 alone has ~2KB of just text that is already present in `event_data`. **Which issue(s) this PR fixes**: Fixes grafana#7395 **Special notes for your reviewer**: I also took the liberty to improve upon the existing test '`Test_renderEntries` by using unique values for each field rather than 10's everywhere. I expect this to conflict with my other PR, grafana#7461.
… 2.7.x (grafana#7690) Fixes the changelog. - PR grafana#7462 and grafana#7461 were **not** included in the 2.7.x release (they were submitted right after the cutoff and did not get backported) and accidentally ended up in the 2.7.x changelog. Moved them up to Main/Unreleased. - Moved grafana#7602 to enhancements section of Promtail
Hello @DylanGuedes!
Please, if the current pull request addresses a bug fix, label it with the |
What this PR does / why we need it:
The windows event log target for Promtail had a typo that led to
EventData
being assigned toUserData
. This PR fixes this typo.Which issue(s) this PR fixes:
Fixes #6167
Special notes for your reviewer:
First time contributing real code! Please let me know if I missed anything :)
Checklist
CONTRIBUTING.md
guideCHANGELOG.md
updateddocs/sources/upgrading/_index.md