moving loki-canary project under loki repo #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mostly working, need to extract out the config needs a proper ksonnet or helm deployment or both needs a makefile
improving tests config via flags added ksonnet config
…he pod name from a file and the downardApi added a makefile
…a direct query to loki to look for logs not received over the websocket before reporting them as missing
…n against entries which were not expected so that we can report them as duplicates.
…second it would cause some way too aggressive querying when scaled out over all our clusters and loki had a hiccup
canary will suspend all operations on SIGINT but not exit, allowing you to shutdown the canary without it being restarted by docker/kubernetes SIGTERM will shutdown everything and end the process
rfratto
approved these changes
Jul 17, 2019
| done chan struct{} | ||
| } | ||
|
|
||
| func NewComparator(writer io.Writer, maxWait time.Duration, pruneInterval time.Duration, |
There was a problem hiding this comment.
This is definitely a nitpick but comparator.NewComparator, reader.NewReader and writer.NewWriter would annoy some go linters and would have comparator.New, reader.New and writer.New be suggested instead. I'm ok with leaving it as it is, but we do have other packages that just use New (loki, distributor, ingester, stage, promtail, etc)
There was a problem hiding this comment.
Good feedback, i'll follow up with a separate PR for this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lots of commits to preserve the history of the canary project