Deprecate CLI flag -ruler.wal-cleaer.period in favor of CLI flag -ruler.wal-cleaner.period

[ssncferreira]

What this PR does / why we need it:

Deprecate CLI flag -ruler.wal-cleaer.period in favor of CLI flag -ruler.wal-cleaner.period.

Which issue(s) this PR fixes:
Fixes #7916 (comment) and #7916 (comment)

NOTE: correctly registring the ruler.wal-cleaner configuration flags is not a breaking change and doesn't require an upgrade guide, because the ruler WAL cleaner initialization code already guarantees that the default values are used:

loki/pkg/ruler/storage/cleaner/cleaner.go

Lines 76 to 101 in c71620a

	func NewWALCleaner(logger log.Logger, manager instance.Manager, metrics *Metrics, walDirectory string, cfg Config) *WALCleaner {
	c := &WALCleaner{
	logger: log.With(logger, "component", "cleaner"),
	instanceManager: manager,
	walDirectory: filepath.Clean(walDirectory),
	walLastModified: lastModified,
	minAge: DefaultCleanupAge,
	period: DefaultCleanupPeriod,
	done: make(chan bool),
	metrics: metrics,
	}
	if cfg.MinAge > 0 {
	c.minAge = cfg.MinAge
	}
	// We allow a period of 0 here because '0' means "don't run the task". This
	// is handled by not running a ticker at all in the run method.
	if cfg.Period >= 0 {
	c.period = cfg.Period
	}
	go c.run()
	return c
	}

Special notes for your reviewer:

Checklist

• Reviewed the CONTRIBUTING.md guide
• Documentation added
• Tests updated
• CHANGELOG.md updated
• Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md

[grafanabot]

./tools/diff_coverage.sh ../loki-target-branch/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

[dannykopping]

LGTM, thanks!

[grafanabot]

./tools/diff_coverage.sh ../loki-target-branch/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%