Build: Remove ./tools/fetch-tags invocation from Makefile #8849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This invocation causes problems when make targets are executed in the build image container (`BUILD_IN_CONTAINER=true`), e.g. the `yacc` target, because git tries to fetch tags from `origin` using ssh, causing error message like these: ``` Host key verification failed. fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. error: Could not fetch origin ``` This is because local ssh keys are not mounted into the build container. In order not to break CI builds (#8232) we need to manually fetch the tags as the first step in release pipelines. This is added to the Drone configuration. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
vlad-diachenko
requested changes
Mar 21, 2023
| @@ -653,8 +666,6 @@ local manifest_ecr(apps, archs) = pipeline('manifest-ecr') { | |||
| RELEASE_TAG_REGEXP: '^([0-9]+\\.[0-9]+\\.[0-9]+)$', | |||
| }, | |||
| commands: [ | |||
| 'apk add --no-cache bash git', | |||
There was a problem hiding this comment.
i will cause an issue that ./tools/image-tag won't be executed becuse it uses bash
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
…d image Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
…in build image Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
|
@vlad-diachenko @MichelHollands @dannykopping Opened a new PR because I don't want to open the can of worms that I did with this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This invocation causes problems when make targets are executed in the build image container (
BUILD_IN_CONTAINER=true), e.g. theyacctarget, because git tries to fetch tags fromoriginusing ssh, causing error message like these:This is because local ssh keys are not mounted into the build container.
In order not to break CI builds
(#8232) we need to manually fetch the tags as the first step in release pipelines. This is added to the Drone configuration.