Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/querier: fix concurrent access to querier tail clients #944

Merged
merged 1 commit into from
Aug 28, 2019

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Aug 28, 2019

The Tailer's querierTailClients was accessed in several goroutines without being protected by a Mutex in each instance; this PR changes the Mutex to a RWMutex and protects each access.

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 9484632 into grafana:master Aug 28, 2019
@rfratto rfratto deleted the tailer_mutex branch September 25, 2019 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants