Fix panic on invalid browser type option #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead this commit changes the API for these methods in order to return an error that must be parsed from the mapping layer.
Now that launch method does not panic, we have to verify the returned error from the Goja execution.
ankur22
reviewed
May 24, 2023
ankur22
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR fixes an issue present since merging #876 due to which execution panicked if the
scenario.options.browser.typeoption was unset or invalid (see this comment's second point). It also improves the error handling from our Go logic, delegating the error to the mapping layer.Closes #894.
Checklist
Tasks