Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TS types #284

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Fix TS types #284

merged 1 commit into from
Jul 15, 2020

Conversation

danielrearden
Copy link
Collaborator

No description provided.

@@ -78,6 +78,6 @@ export function cursorForObjectInConnection<T>(
* otherwise it will be the default.
*/
export function getOffsetWithDefault(
cursor?: ConnectionCursor | null,
cursor: ConnectionCursor | null | undefined,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TS complains because cursor is optional but the next parameter is not, so I just removed the optional and added undefined to the union. I also synced this on the Flow side.

@IvanGoncharov IvanGoncharov added the PR: bug fix 🐞 requires increase of "patch" version number label Jul 15, 2020
@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #284 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #284   +/-   ##
=======================================
  Coverage   99.49%   99.49%           
=======================================
  Files          19       19           
  Lines         595      595           
  Branches       38       38           
=======================================
  Hits          592      592           
  Misses          3        3           
Impacted Files Coverage Δ
src/connection/arrayconnection.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 088990e...b735092. Read the comment docs.

@IvanGoncharov IvanGoncharov merged commit 8f4ed1a into graphql:master Jul 15, 2020
@danielrearden danielrearden deleted the fix-types branch July 15, 2020 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: bug fix 🐞 requires increase of "patch" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants