gridftp: Use example message from RFC 2428 for response to EPSV #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msalle
approved these changes
Aug 18, 2020
|
@ellert: Thanks for making the needed changes to versions and packaging metadata. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title says it all.
Not a big change, but from now on the Globus GridFTP server should use the exact example message for a response to
EPSVfrom RFC 2428, although the difference to a response toPASVcould be already seen from the differences in the actual data part of the response (e.g.(1,2,3,4,195,80)(in response toPASV) and(|||50000|)(in response toEPSV)).The difference to RFC 2428 was noticed during testing UberFTP 2.9-Beta against a Globus GridFTP server 13.20. UberFTP 2.9-Beta uses
EPSVandEPRTby default (both commands are compatible with IPv4 and IPv6 address families) instead ofPASVandPORT.@msalle, @ellert: Sorry, but I'm again unsure about what to change in addition (major, minor version of "globus-gridftp-server-control" and "globus-gridftp-server", packaging information, library version) as this is not a functionality change and I don't expect clients to behave differently due to the changed message. Could you please help me out? :-)