Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exit with error if voms-proxy-init fails #147

Merged
merged 2 commits into from
Feb 26, 2021
Merged

exit with error if voms-proxy-init fails #147

merged 2 commits into from
Feb 26, 2021

Conversation

jbasney
Copy link
Contributor

@jbasney jbasney commented Feb 25, 2021

fixes #68

jbasney and others added 2 commits February 25, 2021 12:20
@jbasney
exit with error if voms-proxy-init fails
92fe5a1 
fixes #68
@fscheiner
Handle second part of #68 in voms_proxy_init()
36e1d57 
Interpret status information provided by waitpid() (in wstatus) and if
possible return actual exit code of the child.
@fscheiner
Copy link
Member

@jbasney
Ok, I also did some renaming (rc(as used by waitpid()) => wstatus) but kept rc as "returncode" for voms_proxy_init() but the logic stays the same.

@fscheiner fscheiner mentioned this pull request Feb 26, 2021
Closed
fscheiner
fscheiner approved these changes Feb 26, 2021
View reviewed changes
Copy link
Member

@fscheiner fscheiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@fscheiner
Copy link
Member

@matyasselmeci
In the "checks" part in #147, there are two lines shown currently, one for "continuous-integration/travis-ci" and one for "Travis CI - Pull Request", where the latter seems to be the "new" one using travis-ci-com instead of travis-ci.org. The first check seems to not run.

Do we need to remove the first check from the (repository) configuration somewhere?

@matyasselmeci
Copy link
Contributor

@fscheiner, I followed the instructions here
https://travis-ci.community/t/known-issue-travis-ci-reports-expected-waiting-for-status-to-be-reported-on-the-github-status-api-but-the-status-never-arrives/1154
and it seems to work now.

@matyasselmeci matyasselmeci merged commit 7a559b3 into gridcf:master Feb 26, 2021
@fscheiner
Copy link
Member

@matyasselmeci
Great! Thanks for solving this.

@fscheiner fscheiner mentioned this pull request Aug 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fscheiner fscheiner fscheiner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

myproxy-logon still returns code 0 when voms-proxy-init called by it fails
3 participants
@jbasney @fscheiner @matyasselmeci