Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camel-case code assist not working for property name completion in map-style constructor invocation #358

Closed
mauromol opened this issue Nov 2, 2017 · 2 comments

Comments

@mauromol
Copy link

mauromol commented Nov 2, 2017

Issue #331 added code assist for property name completion in map-style constructor invocation when the user starts to type the name of a property. However, the current implementation seems to correctly suggest results with a prefix-only guess, not with camel-case (which in Eclipse is usually found elsewhere in code assist, Groovy included).

Consider the slightly modified example:

package c
class MyBean {
	String foo
	void setBar(String bar) {
		foo = bar.toUpperCase()
	}
        String thisIsAPropertyWithALongName
}

And:

package c
class ConstructorTest {
	static main(args) {
		MyBean b = new MyBean(tIAP|)
	}
}

When you invoke code assist at "|", no suggestion is shown.
Please note that:

  • if you do the same after b instance has been created, to directly reference b.thisIsAPropertyWithALongName, camel-case completion works there (i.e.: b.tIAP| <= invoke code assist here)
  • the case in which the property is defined by a setter only (like for MyBean.bar property) should also be covered
@eric-milles
Copy link
Member

Can you re-test this?

@mauromol
Copy link
Author

mauromol commented Nov 3, 2017

With 2.9.2.xx-201711022118-e46 this works fine, thank you! 👍
(sorry, GitHub does not send a mail notification when you just commit, so I may miss some updates until you ping me)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants