Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class rename does not update generic references #442

Closed
mauromol opened this issue Jan 26, 2018 · 7 comments
Closed

Class rename does not update generic references #442

mauromol opened this issue Jan 26, 2018 · 7 comments
Labels
Milestone

Comments

@mauromol
Copy link

Consider the following:

package test20
class MyBean {}

And:

package test20
class Test20 {
	List<MyBean> list
}

Now rename MyBean to MyBean2: the reference to MyBean type in the declaration of Test20.list is not updated with the new name.

@eric-milles eric-milles added this to the v3.0.0 milestone Jan 26, 2018
@eric-milles
Copy link
Member

It all comes down to the indexing performed by org.codehaus.jdt.groovy.integration.internal.GroovyIndexingVisitor. If I add an import, the file gets identified by the indexing search for further AST searching. GroovyIndexingVisitor.visitField has the type visitation commented out.

@eric-milles
Copy link
Member

Ready to test.

@mauromol
Copy link
Author

Hi Eric,
the latest version that gets downloaded if I do "check for updates" is 3.0.0.xx-201801262137-e47, which still exhibits this problem.

@eric-milles
Copy link
Member

eric-milles commented Jan 29, 2018 via email

@mauromol
Copy link
Author

mauromol commented Jan 29, 2018

I tried to clean the Groovy project the test case is in (in order to make Eclipse rebuild it from scratch), isn't it enough to rebuild the index?

Also, your "ready to test" comment was published on 2018-01-27, the latest snapshot is from 2018-01-26... isn't it a snapshot publish problem?

@eric-milles
Copy link
Member

eric-milles commented Jan 29, 2018 via email

@mauromol
Copy link
Author

Ok, thank you, seems to work now, after rebuilding the index. I really thought a complete project rebuild would cause the index to be rebuilt as well.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants