Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent code assist suggestions for range expression #690

Closed
mauromol opened this issue Aug 21, 2018 · 7 comments
Closed

Inconsistent code assist suggestions for range expression #690

mauromol opened this issue Aug 21, 2018 · 7 comments
Assignees
Labels
Milestone

Comments

@mauromol
Copy link

Found while verifying #676.

Ensure auto activation is enabled and type: (1..2).ea. Code assist will be shown and will list each and eachWithIndex. While code assist suggestion list is open, hit Ctrl+Space to cycle through proposals. Otherwise, close the suggestion list and hit ctrl+space: a new suggestion list is shown, including, for instance, forEach.
It seems like that when auto-activation occurs, the range is evaluated as Object, while after you call code assist "manually", it's evaluated as Iterable, hence giving additional proposals.

@mauromol mauromol changed the title Inconsistent code assist suggestion list Inconsistent code assist suggestion list for range Aug 21, 2018
@eric-milles
Copy link
Member

If you pause before typing the dot, does it change? When typing quickly, reconcile does not run and so the semantics of the new code is not known.

@mauromol
Copy link
Author

I tried to type (1..2), wait for 5 seconds, then .eac, but I still see the same behaviour (i.e.: only suggestions for Object, not for Iterable, unless I close the suggestion list and reopen, or cycle through proposal lists).

@mauromol
Copy link
Author

In any case, I would say that I would prefer to be blocked for a while waiting for the reconciler to produce a consistent suggestion list rather than having an inconsistent suggestion list appear quickly...

@eric-milles eric-milles changed the title Inconsistent code assist suggestion list for range Inconsistent code assist suggestions for range expression Aug 21, 2018
@eric-milles
Copy link
Member

Could you increase the auto-activation delay? There may be a number that allows the reconciler to finish and give you the proper suggestions. If we can establish what a working delay is, we can then discuss what a preferred delay would be.

@mauromol
Copy link
Author

I've risen the auto-activation delay up to 5000 ms (a looong delay), but I still see the same behaviour.
I would guess it's not a timing issue, then...

@eric-milles
Copy link
Member

Ready to test

@mauromol
Copy link
Author

Tested with 3.1.0.xx-201808212342-e47, works as expected! 👍
Now just seeing what described in #674 ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants