Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Irrelevant suggestions given when invoking code assist for annotation attributes #769

Closed
mauromol opened this issue Nov 21, 2018 · 3 comments
Closed

Irrelevant suggestions given when invoking code assist for annotation attributes #769

mauromol opened this issue Nov 21, 2018 · 3 comments
Assignees
@eric-milles
Labels
bug
Milestone
v3.2.0

Comments

@mauromol
Copy link

Follow up to #761.

The following screenshots show that useless suggestions are given when invoking code assist for annotation attribute completion:

immagine

In the above case, probably no suggestion at all should be given, or rather just "true"/"false" to replace the current "false"? I don't know how JDT behaves in this case.

immagine

Here only the first 4 suggestions are relevant, the others are not.
@mauromol mauromol changed the title Not meaningful suggestions given when invoking code assist for annotation attributes Irrelevant suggestions given when invoking code assist for annotation attributes Nov 21, 2018
eric-milles added a commit that referenced this issue Nov 25, 2018
@eric-milles
Fix for #769: don't propose types when completing annotation member name
4566617
@eric-milles eric-milles self-assigned this Nov 25, 2018
@eric-milles eric-milles added this to the v3.2.0 milestone Nov 25, 2018
@eric-milles
Copy link
Member

The case of completing a member name should not have type proposals. Value completion is next.

eric-milles added a commit that referenced this issue Nov 25, 2018
@eric-milles
Fix for #769: limit annotation member value proposals to static fields
7741295
@eric-milles
Copy link
Member

Ready to test

@mauromol
Copy link
Author

Works well with 3.2.0.xx-201811260558-e48, thank you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eric-milles eric-milles

Labels
bug
Projects
None yet
Milestone
v3.2.0
Development

No branches or pull requests
2 participants
@mauromol @eric-milles